Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/tikv/gc_worker: Add config to specify gc concurrency manually #10561

Merged
merged 3 commits into from Jun 3, 2019

Conversation

Projects
None yet
3 participants
@MyonKeminta
Copy link
Contributor

commented May 21, 2019

Signed-off-by: MyonKeminta MyonKeminta@users.noreply.github.com

What problem does this PR solve?

Now in master branch TiDB always uses number of up stores as the gc concurrency (now gc concurrency is used for ResolveLocks and will be used for notifying delete range too). However it's useful to make it still configurable. This PR makes it possible to fallback to use configured concurrency, rather than use number of up stores directly.

What is changed and how it works?

This PR adds a new config tikv_gc_auto_concurrency to mysql.tidb. It's defalt value is true. When it's true, tikv_gc_concurrency will be ignored; and when it's false, tikv_gc_concurrency's value will be used as the concurrency.

Check List

Tests

  • Unit test

Related changes

  • Need to update the documentation
Add config to disable auto concurrency
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

@MyonKeminta MyonKeminta changed the title store/tikv: Add config to disable auto concurrency store/tikv/gc_worker: Add config to disable auto concurrency May 21, 2019

@MyonKeminta MyonKeminta changed the title store/tikv/gc_worker: Add config to disable auto concurrency store/tikv/gc_worker: Add config to specify gc concurrency manually May 21, 2019

@codecov

This comment has been minimized.

Copy link

commented May 21, 2019

Codecov Report

Merging #10561 into master will decrease coverage by 0.0059%.
The diff coverage is 43.9024%.

@@               Coverage Diff               @@
##             master     #10561       +/-   ##
===============================================
- Coverage   78.3433%   78.3373%   -0.006%     
===============================================
  Files           414        414               
  Lines         87668      87704       +36     
===============================================
+ Hits          68682      68705       +23     
- Misses        13853      13856        +3     
- Partials       5133       5143       +10
@MyonKeminta

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

@zz-jason zz-jason merged commit 6c31c9b into pingcap:master Jun 3, 2019

8 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 43.9024% of diff hit (target 0%)
Details
codecov/project 78.3373% (-0.006%) compared to d71ce87
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@MyonKeminta MyonKeminta deleted the MyonKeminta:misono/auto-concurrency-config branch Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.