Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: refine HashAgg.Close when unparallelExec #10656

Merged
merged 2 commits into from May 30, 2019

Conversation

@tiancaiamao
Copy link
Contributor

tiancaiamao commented May 30, 2019

Cherry pick #8810

Only the bug fix, without the test code, because the file struct has changed dramaticly and there is no seqtest/seq_executor_test.go in release-2.1

@XuHuaiyu @zz-jason @eurekaka

Copy link
Member

winkyao left a comment

LGTM

Copy link
Member

crazycs520 left a comment

LGTM.
BTW, no need to cherry -pick the test?

@crazycs520

This comment has been minimized.

Copy link
Member

crazycs520 commented May 30, 2019

/run-all-tests

@crazycs520

This comment has been minimized.

Copy link
Member

crazycs520 commented May 30, 2019

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@winkyao winkyao merged commit 5ea2830 into pingcap:release-2.1 May 30, 2019
14 checks passed
14 checks passed
ci/circleci Your tests passed on CircleCI!
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@tiancaiamao tiancaiamao deleted the tiancaiamao:hashagg-close branch Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.