Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: add MySQL extension assignment support for VariableAssignment #10700

Merged
merged 4 commits into from Jun 4, 2019

Conversation

Projects
None yet
4 participants
@tangenta
Copy link
Contributor

commented Jun 4, 2019

What problem does this PR solve?

Update parser for pingcap/parser#346.

What is changed and how it works?

Check List

Tests

  • No code

Code changes

Side effects

Related changes

@CLAassistant

This comment has been minimized.

Copy link

commented Jun 4, 2019

CLA assistant check
All committers have signed the CLA.

@tangenta tangenta force-pushed the tangenta:mysql-ext-assignment branch from 0a97dd7 to 2cc9b58 Jun 4, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 4, 2019

Codecov Report

Merging #10700 into master will decrease coverage by 0.0089%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##            master     #10700       +/-   ##
==============================================
- Coverage   79.633%   79.6241%   -0.009%     
==============================================
  Files          414        414               
  Lines        87696      87736       +40     
==============================================
+ Hits         69835      69859       +24     
- Misses       12687      12698       +11     
- Partials      5174       5179        +5
@winkyao
Copy link
Member

left a comment

LGTM

winkyao and others added some commits Jun 4, 2019

@bb7133

bb7133 approved these changes Jun 4, 2019

Copy link
Contributor

left a comment

LGTM

@tangenta tangenta merged commit d4f2005 into pingcap:master Jun 4, 2019

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.