Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: execute some statement (`create user` `grant` etc) would commit current transaction automically #10707

Merged
merged 2 commits into from Jun 6, 2019

Conversation

Projects
None yet
3 participants
@tiancaiamao
Copy link
Contributor

commented Jun 4, 2019

What problem does this PR solve?

Fix #10705

What is changed and how it works?

New a transaction before "create user", "grant", "revoke" and so on

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch
@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

/run-all-tests

1 similar comment
@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

/run-all-tests

@codecov

This comment has been minimized.

Copy link

commented Jun 4, 2019

Codecov Report

Merging #10707 into master will increase coverage by 0.003%.
The diff coverage is 71.4285%.

@@               Coverage Diff               @@
##             master     #10707       +/-   ##
===============================================
+ Coverage   79.5551%   79.5581%   +0.003%     
===============================================
  Files           415        415               
  Lines         88066      88133       +67     
===============================================
+ Hits          70061      70117       +56     
- Misses        12812      12821        +9     
- Partials       5193       5195        +2
@jackysp
Copy link
Member

left a comment

LGTM

@zimulala
Copy link
Member

left a comment

LGTM

@zimulala zimulala added the status/LGT2 label Jun 6, 2019

@zimulala zimulala merged commit 78881f6 into pingcap:master Jun 6, 2019

8 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 71.4285% of diff hit (target 0%)
Details
codecov/project 79.5581% (+0.003%) compared to bb01a5f
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@tiancaiamao tiancaiamao deleted the tiancaiamao:grant-auto-new-txn branch Jun 6, 2019

tiancaiamao added a commit to tiancaiamao/tidb that referenced this pull request Jun 6, 2019

zz-jason added a commit that referenced this pull request Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.