Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, executor: return TableDual in tryFastPlan for predicate like handlePK=1.1 #10716

Merged
merged 2 commits into from Jun 5, 2019

Conversation

Projects
None yet
3 participants
@XuHuaiyu
Copy link
Contributor

commented Jun 5, 2019

What problem does this PR solve?

Fix #10677

What is changed and how it works?

Return TableDual when the predicate is PKIsHandle = 1.1.

Check List

Tests

  • Integration test

Code changes

  • Has exported function/method change

Side effects

N/A

Related changes

  • Need to cherry-pick to the release branch
@XuHuaiyu

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

/run-all-tests

@zz-jason
Copy link
Member

left a comment

LGTM

need one more review

@@ -3857,6 +3857,22 @@ func (s *testSuite) TestIssue10448(c *C) {
tk.MustQuery("desc select * from t where pk = 9223372036854775808").Check(testkit.Rows("Point_Get_1 1.00 root table:t, handle:9223372036854775808"))
}

func (s *testSuite) TestIssue10677(c *C) {

This comment has been minimized.

Copy link
@zz-jason

zz-jason Jun 5, 2019

Member

maybe it's more proper to move this test to testPointGetSuite

@codecov

This comment has been minimized.

Copy link

commented Jun 5, 2019

Codecov Report

Merging #10716 into master will increase coverage by 0.0139%.
The diff coverage is 50%.

@@               Coverage Diff                @@
##             master     #10716        +/-   ##
================================================
+ Coverage   79.6677%   79.6816%   +0.0139%     
================================================
  Files           414        414                
  Lines         87811      87827        +16     
================================================
+ Hits          69957      69982        +25     
+ Misses        12674      12667         -7     
+ Partials       5180       5178         -2
@qw4990

qw4990 approved these changes Jun 5, 2019

Copy link
Contributor

left a comment

LGTM

@XuHuaiyu

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

/run-all-tests

@XuHuaiyu XuHuaiyu added the status/LGT2 label Jun 5, 2019

@XuHuaiyu XuHuaiyu merged commit 1fb0e97 into pingcap:master Jun 5, 2019

16 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 50% of diff hit (target 0%)
Details
codecov/project 79.6816% (+0.0139%) compared to 08e4bd9
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@XuHuaiyu XuHuaiyu deleted the XuHuaiyu:point_get_decimal branch Jun 5, 2019

XuHuaiyu added a commit to XuHuaiyu/tidb that referenced this pull request Jun 6, 2019

zz-jason added a commit that referenced this pull request Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.