Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add_date can return mysql.Time (#9830) #10718

Merged
merged 7 commits into from Jun 20, 2019
Merged

Conversation

@winoros
Copy link
Member

winoros commented Jun 5, 2019

What problem does this PR solve?

cherry-pick #9830

}

// StrLenOfInt64Fast efficiently calculate the string character lengths of an int64 as input
func StrLenOfInt64Fast(x int64) int {

This comment has been minimized.

Copy link
@lamxTyler

lamxTyler Jun 5, 2019

Member

Seems that they are not used?

This comment has been minimized.

Copy link
@winoros

winoros Jun 6, 2019

Author Member

Yes, just copied the whole file

This comment has been minimized.

Copy link
@zz-jason

zz-jason Jun 10, 2019

Member

is this function introduced by another pr, and that pr is not cherry-picked to release 2.1?

@qw4990

This comment has been minimized.

Copy link
Contributor

qw4990 commented Jun 6, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

Copy link
Contributor

qw4990 left a comment

LGTM

Copy link
Member

zz-jason left a comment

LGTM

zz-jason added 2 commits Jun 20, 2019
@zz-jason zz-jason merged commit 7b8e174 into pingcap:release-2.1 Jun 20, 2019
6 checks passed
6 checks passed
ci/circleci Your tests passed on CircleCI!
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@winoros winoros deleted the winoros:pick branch Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.