Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add config item for bind info lease #10725

Merged
merged 2 commits into from Jun 5, 2019

Conversation

3 participants
@lamxTyler
Copy link
Member

commented Jun 5, 2019

What problem does this PR solve?

Fix #9606

What is changed and how it works?

Add one config item for the bind info lease and the default value is 3s.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    Change the bind info lease to 0 and verifies that the two background goroutine does not exist.

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch

@lamxTyler lamxTyler requested review from zz-jason, qw4990, winoros and XuHuaiyu Jun 5, 2019

@lamxTyler lamxTyler added this to In progress in sql plan management via automation Jun 5, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 5, 2019

Codecov Report

Merging #10725 into master will increase coverage by 0.0111%.
The diff coverage is 66.6666%.

@@               Coverage Diff                @@
##             master     #10725        +/-   ##
================================================
+ Coverage   79.6565%   79.6676%   +0.0111%     
================================================
  Files           414        414                
  Lines         87817      87865        +48     
================================================
+ Hits          69952      70000        +48     
+ Misses        12682      12680         -2     
- Partials       5183       5185         +2
1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Jun 5, 2019

Codecov Report

Merging #10725 into master will increase coverage by 0.0111%.
The diff coverage is 66.6666%.

@@               Coverage Diff                @@
##             master     #10725        +/-   ##
================================================
+ Coverage   79.6565%   79.6676%   +0.0111%     
================================================
  Files           414        414                
  Lines         87817      87865        +48     
================================================
+ Hits          69952      70000        +48     
+ Misses        12682      12680         -2     
- Partials       5183       5185         +2
@zz-jason
Copy link
Member

left a comment

LGTM

sql plan management automation moved this from In progress to Reviewer approved Jun 5, 2019

@XuHuaiyu
Copy link
Contributor

left a comment

LGTM

@XuHuaiyu XuHuaiyu merged commit 54e4894 into pingcap:master Jun 5, 2019

8 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 66.6666% of diff hit (target 0%)
Details
codecov/project 79.6676% (+0.0111%) compared to 1fb0e97
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

sql plan management automation moved this from Reviewer approved to Done Jun 5, 2019

@lamxTyler lamxTyler deleted the lamxTyler:bind-lease branch Jun 5, 2019

@lamxTyler lamxTyler added status/LGT2 and removed status/LGT1 labels Jun 5, 2019

lamxTyler added a commit to lamxTyler/tidb that referenced this pull request Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.