Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix issue that `monthname` is not compatible with Mysql (#10109) #10733

Merged
merged 2 commits into from Jun 6, 2019

Conversation

@qw4990
Copy link
Contributor

qw4990 commented Jun 6, 2019

cherry-pick for #10109

@qw4990

This comment has been minimized.

Copy link
Contributor Author

qw4990 commented Jun 6, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@qw4990 qw4990 requested review from lamxTyler and zz-jason Jun 6, 2019
Copy link
Member

zimulala left a comment

LGTM

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Jun 6, 2019

@qw4990 Please fix ci and resolve conflicts

@zimulala zimulala added the status/LGT1 label Jun 6, 2019
@qw4990 qw4990 force-pushed the qw4990:release-2.1-10109 branch from 249e974 to 66b0c2d Jun 6, 2019
@qw4990

This comment has been minimized.

Copy link
Contributor Author

qw4990 commented Jun 6, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

Copy link
Member

zz-jason left a comment

LGTM

@zz-jason zz-jason merged commit 8a795d2 into pingcap:release-2.1 Jun 6, 2019
14 checks passed
14 checks passed
ci/circleci Your tests passed on CircleCI!
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.