Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv: remove max grpc msg limitation for kv request #11005

Merged
merged 2 commits into from Jul 1, 2019

Conversation

Projects
None yet
3 participants
@lysu
Copy link
Member

commented Jul 1, 2019

What problem does this PR solve?

this pr works with tikv/tikv#4992

grpc msg limitation is hard to pre-calculate and we already have

const txnCommitBatchSize = 16 * 1024
to control commit msg size

and

ef6590e#diff-c27388ffb48c6f6eaeefe07dd3243530R240 to control query msg size

in upper level.

What is changed and how it works?

remove max grpc msg limitation for kv request

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • remove code

Side effects

  • N/A

Related changes

  • Need to cherry-pick to the release branch

This change is Reviewable

@lysu lysu added the component/tikv label Jul 1, 2019

@ngaut

ngaut approved these changes Jul 1, 2019

Copy link
Member

left a comment

LGTM

@jackysp

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

/run-all-tests

@jackysp

jackysp approved these changes Jul 1, 2019

Copy link
Member

left a comment

LGTM

@jackysp jackysp merged commit 5fd7ed7 into pingcap:master Jul 1, 2019

14 checks passed

ci/circleci Your tests passed on CircleCI!
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@lysu lysu deleted the lysu:dev-remove-grpc-msg-limit branch Jul 3, 2019

lysu added a commit to lysu/tidb that referenced this pull request Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.