Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix point get snapshot TS for pessimistic transaction. #11012

Merged
merged 1 commit into from Jul 1, 2019

Conversation

Projects
None yet
3 participants
@coocood
Copy link
Member

commented Jul 1, 2019

What problem does this PR solve?

Select for update use PointGet executor, the TS for the snapshot always use startTS, result in wrong result.

What is changed and how it works?

Set the snapshot TS to forUpdateTS if the point get locks the key.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch
@coocood

This comment has been minimized.

Copy link
Member Author

commented Jul 1, 2019

/run-all-tests

@codecov

This comment has been minimized.

Copy link

commented Jul 1, 2019

Codecov Report

Merging #11012 into master will decrease coverage by 0.0651%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##             master    #11012        +/-   ##
===============================================
- Coverage   81.0171%   80.952%   -0.0652%     
===============================================
  Files           418       418                
  Lines         89428     89264       -164     
===============================================
- Hits          72452     72261       -191     
- Misses        11739     11764        +25     
- Partials       5237      5239         +2
@jackysp
Copy link
Member

left a comment

LGTM

@tiancaiamao

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

LGTM

@jackysp

jackysp approved these changes Jul 1, 2019

@jackysp jackysp merged commit 08d8219 into pingcap:master Jul 1, 2019

16 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 0%)
Details
codecov/project Absolute coverage decreased by -0.0651% but relative coverage increased by +18.9828% compared to 5fd7ed7
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the coocood:fix-point-get-ts branch Jul 1, 2019

coocood added a commit that referenced this pull request Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.