Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config, kv: make TxnEntryCountLimit and TxnTotalSizeLimit configurable #11058

Merged
merged 4 commits into from Jul 4, 2019

Conversation

Projects
None yet
3 participants
@jackysp
Copy link
Member

commented Jul 3, 2019

What problem does this PR solve?

Cherry-pick (#9035) to master.

What is changed and how it works?

It is useful if we make the transaction size limit configurable.

Check List

Tests

  • Unit test

Code changes

  • Has exported variable/fields change

Side effects

  • Increased code complexity
@codecov

This comment has been minimized.

Copy link

commented Jul 3, 2019

Codecov Report

Merging #11058 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #11058   +/-   ##
===========================================
  Coverage   81.1018%   81.1018%           
===========================================
  Files           419        419           
  Lines         89924      89924           
===========================================
  Hits          72930      72930           
  Misses        11725      11725           
  Partials       5269       5269
@coocood

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

LGTM

@jackysp

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2019

/run-all-tests

@jackysp

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2019

/run-unit-test

@lysu

lysu approved these changes Jul 3, 2019

Copy link
Member

left a comment

LGTM

@jackysp

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2019

/run-unit-test

@jackysp jackysp merged commit c786228 into pingcap:master Jul 4, 2019

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.