Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
executor: fix invalid key error of fast analyze #11072
What problem does this PR solve?
What is changed and how it works?
We should check the validity of iterator before using them.
@@ Coverage Diff @@ ## master #11072 +/- ## ================================================ - Coverage 80.9685% 80.9393% -0.0293% ================================================ Files 419 418 -1 Lines 89326 89194 -132 ================================================ - Hits 72326 72193 -133 + Misses 11767 11759 -8 - Partials 5233 5242 +9
@@ Coverage Diff @@ ## master #11072 +/- ## =========================================== Coverage 81.2155% 81.2155% =========================================== Files 419 419 Lines 90117 90117 =========================================== Hits 73189 73189 Misses 11656 11656 Partials 5272 5272
1 similar comment
Jul 4, 2019
13 of 14 checks passed
ci/circleci Your tests are queued behind your running buildsDetails
idc-jenkins-ci-tidb/build Jenkins job succeeded.Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.Details
idc-jenkins-ci-tidb/common-test job succeededDetails
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.Details
idc-jenkins-ci-tidb/mybatis-test job succeededDetails
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.Details
license/cla Contributor License Agreement is signed.Details
referenced this pull request
Jul 5, 2019
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.