Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: handle unsigned primary key for fast analyze #11074

Merged
merged 2 commits into from Jul 4, 2019

Conversation

Projects
None yet
4 participants
@lamxTyler
Copy link
Member

commented Jul 4, 2019

What problem does this PR solve?

Currently, fast analyze treat all handle column as signed int64, it will produce wrong stats if there are values greater than MaxInt64.

What is changed and how it works?

If the primary key has unsigned flag, convert the handle id to unsigned uint64.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch
@codecov

This comment has been minimized.

Copy link

commented Jul 4, 2019

Codecov Report

Merging #11074 into master will decrease coverage by 0.0873%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #11074        +/-   ##
================================================
- Coverage   80.9954%   80.9081%   -0.0874%     
================================================
  Files           419        418         -1     
  Lines         89384      89195       -189     
================================================
- Hits          72397      72166       -231     
- Misses        11759      11795        +36     
- Partials       5228       5234         +6
@zz-jason
Copy link
Member

left a comment

LGTM

@zz-jason zz-jason added the status/LGT1 label Jul 4, 2019

@winoros
Copy link
Member

left a comment

lgtm

@winoros

winoros approved these changes Jul 4, 2019

@lamxTyler lamxTyler added status/LGT2 and removed status/LGT1 labels Jul 4, 2019

@lamxTyler

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2019

/run-all-tests

@jackysp jackysp merged commit ce0312b into pingcap:master Jul 4, 2019

14 checks passed

ci/circleci Your tests passed on CircleCI!
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@lamxTyler lamxTyler deleted the lamxTyler:unsigned branch Jul 4, 2019

lamxTyler added a commit to lamxTyler/tidb that referenced this pull request Jul 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.