Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikvclient: fix a bug that double close channels. (#10991) #11101

Merged
merged 4 commits into from Jul 9, 2019

Conversation

@hicqu
Copy link
Contributor

hicqu commented Jul 5, 2019

cherry pick #10991

@hicqu hicqu force-pushed the hicqu:release-3.0 branch from 090d7c2 to 000723f Jul 5, 2019
@hicqu hicqu force-pushed the hicqu:release-3.0 branch from 000723f to bf5bc66 Jul 5, 2019
@hicqu hicqu requested a review from tiancaiamao Jul 5, 2019
@tiancaiamao

This comment has been minimized.

Copy link
Contributor

tiancaiamao commented Jul 5, 2019

LGTM

@lysu
lysu approved these changes Jul 5, 2019
Copy link
Member

lysu left a comment

LGTM

@lysu

This comment has been minimized.

Copy link
Member

lysu commented Jul 5, 2019

/run-all-tests

@winkyao

This comment has been minimized.

Copy link
Member

winkyao commented Jul 7, 2019

/run-all-tests

@winkyao

This comment has been minimized.

Copy link
Member

winkyao commented Jul 7, 2019

@hicqu Please fix ci

@hicqu

This comment has been minimized.

Copy link
Contributor Author

hicqu commented Jul 8, 2019

For the mysql test it's not caused by this commit. Seems @zz-jason is fixing it?

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Jul 8, 2019

/run-integration-common-test
/run-common-test
/run-unit-test

@zz-jason zz-jason added status/LGT2 and removed status/LGT1 labels Jul 8, 2019
@crazycs520

This comment has been minimized.

Copy link
Member

crazycs520 commented Jul 8, 2019

/run-all-tests

@zz-jason

This comment has been minimized.

Copy link
Member

zz-jason commented Jul 9, 2019

/run-unit-test

@zz-jason zz-jason merged commit 73c34e1 into pingcap:release-3.0 Jul 9, 2019
14 checks passed
14 checks passed
ci/circleci Your tests passed on CircleCI!
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@hicqu hicqu deleted the hicqu:release-3.0 branch Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.