Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: refine error messages in unsupported column options (#11065) #11274

Merged
merged 2 commits into from Jul 19, 2019

Conversation

@tangenta
Copy link
Contributor

commented Jul 16, 2019

Cherry-pick #11065.

@tangenta

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2019

/run-all-tests

@tangenta

This comment has been minimized.

Copy link
Contributor Author

commented Jul 18, 2019

@zz-jason
Copy link
Member

left a comment

It's better to also cherry-pick the test code.

@tangenta tangenta force-pushed the tangenta:release-3.0 branch from d4f2b36 to 3f109ce Jul 19, 2019

@tangenta

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2019

My mistake. PTAL @zz-jason

@zz-jason

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

LGTM

@zimulala
Copy link
Member

left a comment

LGTM

@zz-jason zz-jason merged commit ffe55b8 into pingcap:release-3.0 Jul 19, 2019

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.