Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infochema, server: export region_id in hot_region table (#10982) #11350

Merged
merged 5 commits into from Jul 25, 2019
Merged

infochema, server: export region_id in hot_region table (#10982) #11350

merged 5 commits into from Jul 25, 2019

Conversation

lysu
Copy link
Collaborator

@lysu lysu commented Jul 22, 2019 •
edited

cherry-pick #10982 to 3.0

This change is Reviewable

@lysu
Copy link
Collaborator Author

lysu commented Jul 22, 2019

/run-all-tests

zz-jason
zz-jason reviewed Jul 23, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 23, 2019
@zz-jason zz-jason requested a review from winoros July 23, 2019 01:37
@zz-jason
Copy link
Member

/run-common-test
/run-integration-common-test

winoros
winoros approved these changes Jul 23, 2019
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lysu
Copy link
Collaborator Author

lysu commented Jul 23, 2019

/run-all-tests

@lysu lysu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 23, 2019
@zz-jason
Copy link
Member

/run-all-tests

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Jul 24, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Jul 24, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jul 24, 2019

@lysu merge failed.

@zz-jason
Copy link
Member

/run-unit-test

@zz-jason zz-jason merged commit cfcd4db into pingcap:release-3.0 Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
component/server status/can-merge Indicates a PR has been approved by a committer. type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lysu @zz-jason @sre-bot @winoros