Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
ddl: Fix generated column can refer only to generated columns defined prior to it. #11549
What problem does this PR solve?
This PR tries to solve the following bug that caused by the order of generated columns and non-generated columns:
In MySQL 5.7 & 8.0:
Before putting add generated column to ddl job, computing the generated column offset itself and judging the relation with depended generated column offset as well.
What is changed and how it works?
Find the generated column offset itself in func
changed the title
Fix generated column can refer only to generated columns defined prior to it.
Jul 31, 2019
@@ Coverage Diff @@ ## master #11549 +/- ## ================================================ - Coverage 81.8655% 81.2079% -0.6577% ================================================ Files 427 426 -1 Lines 94759 91874 -2885 ================================================ - Hits 77575 74609 -2966 - Misses 11830 11895 +65 - Partials 5354 5370 +16
Thx very much.
I've changed it: PTAL