Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: implement projection and table dual in cascades #11664

Merged
merged 5 commits into from Aug 8, 2019

Conversation

@eurekaka
Copy link
Contributor

commented Aug 7, 2019

What problem does this PR solve?

Not a problem, this is part of the new cascades planner. This PR is split from #11566.

What is changed and how it works?

Add implementation rules for LogicalProjection and LogicalTableDual. After this PR, we can run select 1 query when cascades planner is enabled.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

N/A

Related changes

N/A

@eurekaka eurekaka force-pushed the eurekaka:cas/proj_dual branch from 2732e17 to b1bf97f Aug 7, 2019

@eurekaka

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

/run-all-tests

Show resolved Hide resolved planner/core/plan.go Outdated
Show resolved Hide resolved planner/core/logical_plans.go Outdated
@codecov

This comment has been minimized.

Copy link

commented Aug 8, 2019

Codecov Report

Merging #11664 into master will increase coverage by 0.3462%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #11664        +/-   ##
================================================
+ Coverage   81.5192%   81.8655%   +0.3463%     
================================================
  Files           426        427         +1     
  Lines         93492      94759      +1267     
================================================
+ Hits          76214      77575      +1361     
+ Misses        11881      11830        -51     
+ Partials       5397       5354        -43

@eurekaka eurekaka requested review from zz-jason and lamxTyler Aug 8, 2019

@lamxTyler
Copy link
Member

left a comment

LGTM

@eurekaka eurekaka added the status/LGT1 label Aug 8, 2019

@eurekaka eurekaka requested a review from lzmhhh123 Aug 8, 2019

@zz-jason
Copy link
Member

left a comment

LGTM

@sre-bot

This comment has been minimized.

Copy link

commented Aug 8, 2019

/run-all-tests

@sre-bot sre-bot merged commit f74b9e9 into pingcap:master Aug 8, 2019

14 checks passed

ci/circleci Your tests passed on CircleCI!
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@eurekaka eurekaka deleted the eurekaka:cas/proj_dual branch Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.