Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: replace `context.WithValue` string key to typed `struct{}` key #11675

Merged
merged 2 commits into from Aug 9, 2019

Conversation

@lauhg
Copy link
Contributor

commented Aug 8, 2019

Improve performance

What problem does this PR solve?

fixes #11634

What is changed and how it works?

replace context.WithValue string key and int key to typed struct{} key

Check List

Tests

  • None

Code changes

  • Has exported variable/fields change

Side effects

  • None

Related changes

  • None

@sre-bot sre-bot added the contribution label Aug 8, 2019

@sre-bot

This comment has been minimized.

Copy link

commented Aug 8, 2019

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@CLAassistant

This comment has been minimized.

Copy link

commented Aug 8, 2019

CLA assistant check
All committers have signed the CLA.

@codecov

This comment has been minimized.

Copy link

commented Aug 8, 2019

Codecov Report

Merging #11675 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master    #11675   +/-   ##
=========================================
  Coverage   81.667%   81.667%           
=========================================
  Files          428       428           
  Lines        93820     93820           
=========================================
  Hits         76620     76620           
  Misses       11790     11790           
  Partials      5410      5410

@lauhg lauhg force-pushed the lauhg:optimize-context-key branch from 4abf648 to b8c0d34 Aug 8, 2019

@lysu

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

/run-all-tests

@lysu
Copy link
Member

left a comment

Thank you for your contribution!

LGTM

@jackysp

jackysp approved these changes Aug 9, 2019

Copy link
Member

left a comment

LGTM

@sre-bot

This comment has been minimized.

Copy link

commented Aug 9, 2019

/run-all-tests

@sre-bot

This comment has been minimized.

Copy link

commented Aug 9, 2019

@lauhg merge failed.

@tiancaiamao

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

/rebuild

@tiancaiamao

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

/run-unit-test

@tiancaiamao tiancaiamao merged commit 1595c01 into pingcap:master Aug 9, 2019

14 checks passed

ci/circleci Your tests passed on CircleCI!
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.