Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix last_day incompatible with mysql #11704

Merged
merged 2 commits into from Aug 10, 2019

Conversation

@TennyZhuang
Copy link
Contributor

commented Aug 10, 2019

What problem does this PR solve?

fixes #11695

What is changed and how it works?

Changed is described in issue.

Assert day is not 0 before calculate last_da

Check List

Tests

  • Unit test

Code changes

Side effects

  • Breaking backward compatibility

Related changes

@sre-bot

This comment has been minimized.

Copy link

commented Aug 10, 2019

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@codecov

This comment has been minimized.

Copy link

commented Aug 10, 2019

Codecov Report

Merging #11704 into master will decrease coverage by 0.2058%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##             master    #11704        +/-   ##
===============================================
- Coverage   81.6469%   81.441%   -0.2059%     
===============================================
  Files           429       429                
  Lines         93614     92597      -1017     
===============================================
- Hits          76433     75412      -1021     
- Misses        11780     11796        +16     
+ Partials       5401      5389        -12
@codecov

This comment has been minimized.

Copy link

commented Aug 10, 2019

Codecov Report

Merging #11704 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #11704   +/-   ##
===========================================
  Coverage   81.4323%   81.4323%           
===========================================
  Files           429        429           
  Lines         92645      92645           
===========================================
  Hits          75443      75443           
  Misses        11808      11808           
  Partials       5394       5394
@zz-jason
Copy link
Member

left a comment

LGTM

@zz-jason

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

@TennyZhuang Thanks for your contribution. Can you modify the PR description to use the "Closing issues using keywords" feature of github? It helps us to automatically close the issue when this PR is merged.

@TennyZhuang

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

@zz-jason Updated

@ngaut

ngaut approved these changes Aug 10, 2019

@sre-bot

This comment has been minimized.

Copy link

commented Aug 10, 2019

/run-all-tests

@sre-bot

This comment has been minimized.

Copy link

commented Aug 10, 2019

@TennyZhuang merge failed.

@ngaut ngaut merged commit ff71c0c into pingcap:master Aug 10, 2019

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@TennyZhuang TennyZhuang deleted the TennyZhuang:bugfix/time-last-day branch Aug 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.