Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: enable vectorized expression evaluation by default #11965

Merged
merged 22 commits into from Sep 3, 2019

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Sep 1, 2019

What problem does this PR solve?

Change the default value of EnableVectorizedExpression to enable vectorized expression evaluation by default.

What is changed and how it works?

  1. Change the DefEnableVectorizedExpression to true;
  2. Some bugfix on vectorized evaluation framework.

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 1, 2019

/run-all-tests

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 1, 2019

/run-unit-test

@codecov
Copy link

codecov bot commented Sep 2, 2019

Codecov Report

Merging #11965 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #11965   +/-   ##
===========================================
  Coverage   81.4027%   81.4027%           
===========================================
  Files           444        444           
  Lines         95444      95444           
===========================================
  Hits          77694      77694           
  Misses        12250      12250           
  Partials       5500       5500

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 2, 2019

/run-all-tests

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 2, 2019

/run-all-tests

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 2, 2019

/run-all-tests

expression/column.go Show resolved Hide resolved
expression/vectorized.go Outdated Show resolved Hide resolved
util/chunk/column.go Show resolved Hide resolved
expression/column.go Show resolved Hide resolved
util/chunk/column.go Outdated Show resolved Hide resolved
expression/column.go Show resolved Hide resolved
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 2, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 3, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 3, 2019

/run-all-tests

@sre-bot sre-bot merged commit b90ebe1 into pingcap:master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants