Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: enable vectorized expression evaluation by default #11965

Merged
merged 22 commits into from Sep 3, 2019

Conversation

@qw4990
Copy link
Contributor

commented Sep 1, 2019

What problem does this PR solve?

Change the default value of EnableVectorizedExpression to enable vectorized expression evaluation by default.

What is changed and how it works?

  1. Change the DefEnableVectorizedExpression to true;
  2. Some bugfix on vectorized evaluation framework.
@qw4990

This comment has been minimized.

Copy link
Contributor Author

commented Sep 1, 2019

/run-all-tests

@qw4990

This comment has been minimized.

Copy link
Contributor Author

commented Sep 1, 2019

/run-unit-test

@codecov

This comment has been minimized.

Copy link

commented Sep 2, 2019

Codecov Report

Merging #11965 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #11965   +/-   ##
===========================================
  Coverage   81.4027%   81.4027%           
===========================================
  Files           444        444           
  Lines         95444      95444           
===========================================
  Hits          77694      77694           
  Misses        12250      12250           
  Partials       5500       5500
@qw4990

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

/run-all-tests

@qw4990

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

/run-all-tests

expression/chunk_executor.go Outdated Show resolved Hide resolved
@qw4990

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

/run-all-tests

qw4990 added 2 commits Sep 2, 2019
expression/column.go Show resolved Hide resolved
expression/vectorized.go Outdated Show resolved Hide resolved
qw4990 added 3 commits Sep 2, 2019
util/chunk/column.go Show resolved Hide resolved
expression/column.go Show resolved Hide resolved
util/chunk/column.go Outdated Show resolved Hide resolved
expression/column.go Show resolved Hide resolved

@qw4990 qw4990 requested review from XuHuaiyu, zz-jason and SunRunAway Sep 2, 2019

@SunRunAway
Copy link
Member

left a comment

LGTM

@zz-jason
Copy link
Member

left a comment

LGTM

@sre-bot

This comment has been minimized.

Copy link

commented Sep 3, 2019

/run-all-tests

@sre-bot sre-bot merged commit b90ebe1 into pingcap:master Sep 3, 2019

13 checks passed

idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.