Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: support vectorized bitmap operations for `nulls` in `Column` #12034

Merged
merged 8 commits into from Sep 5, 2019

Conversation

@qw4990
Copy link
Contributor

commented Sep 5, 2019

What problem does this PR solve?

Introduce a new method MergeNulls for Column.

What is changed and how it works?

BenchmarkMergeNullsVectorized-12         5000000               265 ns/op               0 B/op          0 allocs/op
BenchmarkMergeNullsNonVectorized-12       500000              3068 ns/op               0 B/op          0 allocs/op

Check List

Tests

  • Unit test
@codecov

This comment has been minimized.

Copy link

commented Sep 5, 2019

Codecov Report

Merging #12034 into master will increase coverage by 0.041%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##             master     #12034       +/-   ##
===============================================
+ Coverage   81.3248%   81.3659%   +0.041%     
===============================================
  Files           447        447               
  Lines         95662      95583       -79     
===============================================
- Hits          77797      77772       -25     
+ Misses        12317      12284       -33     
+ Partials       5548       5527       -21
util/chunk/column.go Outdated Show resolved Hide resolved
@zz-jason
Copy link
Member

left a comment

please add a UT.

util/chunk/column.go Outdated Show resolved Hide resolved

@qw4990 qw4990 requested review from SunRunAway and zz-jason Sep 5, 2019

@SunRunAway
Copy link
Member

left a comment

~

@SunRunAway SunRunAway added status/LGT1 and removed status/LGT1 labels Sep 5, 2019

util/chunk/column_test.go Outdated Show resolved Hide resolved
util/chunk/column_test.go Outdated Show resolved Hide resolved
qw4990 and others added 2 commits Sep 5, 2019
Update util/chunk/column_test.go
Co-Authored-By: Feng Liyuan <darktemplar.f@gmail.com>
Update util/chunk/column_test.go
Co-Authored-By: Feng Liyuan <darktemplar.f@gmail.com>
@SunRunAway
Copy link
Member

left a comment

LGTM

@SunRunAway

This comment has been minimized.

Copy link
Member

commented Sep 5, 2019

@qw4990 Please update PR description and benchmark result.

@zz-jason
Copy link
Member

left a comment

LGTM

@sre-bot

This comment has been minimized.

Copy link

commented Sep 5, 2019

/run-all-tests

@qw4990 qw4990 removed the status/LGT1 label Sep 5, 2019

@qw4990 qw4990 added the status/LGT2 label Sep 5, 2019

@qw4990

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2019

@qw4990 Please update PR description and benchmark result.

Updated.

@sre-bot sre-bot merged commit 1b0f61a into pingcap:master Sep 5, 2019

13 checks passed

idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
jingyugao added a commit to jingyugao/tidb that referenced this pull request Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.