Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: support display invalid key in stats buckets (#12064) #12094

Merged
merged 8 commits into from Sep 12, 2019

Conversation

@sre-bot
Copy link

commented Sep 9, 2019

cherry-pick #12064 to release-3.0


What problem does this PR solve?

show stats_buckets sometimes shows errors like invalid encoded key flag 252.

What is changed and how it works?

Feedback may generate invalid index keys, we need to handle these when trying to display values instead of raise errors.

Check List

Tests

  • Unit test
    Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch

Release note

  • support display invalid key in stats buckets
@sre-bot

This comment has been minimized.

Copy link
Author

commented Sep 9, 2019

/run-all-tests

lamxTyler and others added 2 commits Sep 9, 2019
Copy link
Member

left a comment

LGTM

@zz-jason zz-jason added the status/LGT1 label Sep 9, 2019
Copy link
Member

left a comment

LGTM.

@sre-bot

This comment has been minimized.

Copy link
Author

commented Sep 10, 2019

/run-all-tests

@sre-bot

This comment has been minimized.

Copy link
Author

commented Sep 10, 2019

@sre-bot merge failed.

@zz-jason

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

/merge

@sre-bot

This comment has been minimized.

Copy link
Author

commented Sep 10, 2019

Your auto merge job has been accepted, waiting for #11953, #12052, #11957

@sre-bot

This comment has been minimized.

Copy link
Author

commented Sep 10, 2019

/run-all-tests

@sre-bot

This comment has been minimized.

Copy link
Author

commented Sep 10, 2019

@sre-bot merge failed.

@zz-jason

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

/merge

@sre-bot

This comment has been minimized.

Copy link
Author

commented Sep 11, 2019

Your auto merge job has been accepted, waiting for #12127

@sre-bot

This comment has been minimized.

Copy link
Author

commented Sep 11, 2019

/run-all-tests

@sre-bot

This comment has been minimized.

Copy link
Author

commented Sep 11, 2019

@sre-bot merge failed.

@zz-jason

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

/rebuild

@zz-jason zz-jason merged commit 299da1b into pingcap:release-3.0 Sep 12, 2019
5 of 6 checks passed
5 of 6 checks passed
idc-jenkins-ci-tidb/unit-test Jenkins job is running.
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.