Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: disable local latch by default (#12068) #12095

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@sre-bot
Copy link

commented Sep 9, 2019

cherry-pick #12068 to release-3.0


Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What problem does this PR solve?

The local latch has a large memory usage for TiDB when importing data. In addition, there is a problem of inconsistency in the error message of the write conflict. After TiDB 3.0 supported pessimistic transaction, its role in reducing conflicts was also weakened. So, it is best to turn it off by default.

What is changed and how it works?

Turn it off by default.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the tidb-ansible repository
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@sre-bot

This comment has been minimized.

Copy link
Author

commented Sep 9, 2019

/run-all-tests

Copy link
Member

left a comment

LGTM

@coocood
coocood approved these changes Sep 9, 2019
Copy link
Member

left a comment

LGTM

@coocood coocood merged commit 7f41ed3 into pingcap:release-3.0 Sep 9, 2019
13 checks passed
13 checks passed
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.