Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type: add db prefix to function name for not exist error messages (#11156) #12111

Merged
merged 4 commits into from Sep 10, 2019

Conversation

@zz-jason
Copy link
Member

commented Sep 10, 2019

cherry pick #11156 to release 3.0


What problem does this PR solve?

Close #11147

What is changed and how it works?

add db prefix to function name for not exist error messages

Check List

Tests

  • Unit test
  • Integration test
Copy link
Member

left a comment

lgtm

Copy link
Contributor

left a comment

The mode of expression/scalar_function_test.go is changed. It seems unexcepted.

@zz-jason

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

The mode of expression/scalar_function_test.go is changed. It seems unexcepted.

@XuHuaiyu Changed back

Copy link
Contributor

left a comment

LGTM

@zz-jason zz-jason merged commit 7f1f66e into pingcap:release-3.0 Sep 10, 2019
5 of 6 checks passed
5 of 6 checks passed
idc-jenkins-ci-tidb/unit-test Jenkins job is running.
Details
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@zz-jason zz-jason deleted the zz-jason:cherry-pick/3.0-11156 branch Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.