Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sessionctx/variable: refine slow log output by not print useless info (#12016) #12144

Merged
merged 4 commits into from Sep 11, 2019

Conversation

@sre-bot
Copy link

commented Sep 11, 2019

cherry-pick #12016 to release-3.0


What problem does this PR solve?

What is changed and how it works

No need to print cop info when there is no cop task.

eg:

# Time: 2019-09-03T22:29:15.928961+08:00
# Txn_start_ts: 0
# User: root@::1
# Conn_ID: 1
# Query_time: 4.55850739
# DB: test
# Is_internal: false
# Digest: ff607ecdf92ded60eae3d47bd165392258321403520610cf5354fd5cf7057c53
# Num_cop_tasks: 0
# Cop_proc_avg: 0 Cop_proc_p90: 0 Cop_proc_max: 0 Cop_proc_addr:
# Cop_wait_avg: 0 Cop_wait_p90: 0 Cop_wait_max: 0 Cop_wait_addr:
# Succ: true
split table t between (0) and (10000) regions 5;

As you can see, Num_cop_tasks is 0, then the cop log is redundant.

@sre-bot

This comment has been minimized.

Copy link
Author

commented Sep 11, 2019

/run-all-tests

Copy link
Member

left a comment

LGTM

Copy link
Member

left a comment

LGTM

@sre-bot

This comment has been minimized.

Copy link
Author

commented Sep 11, 2019

/run-all-tests

@sre-bot sre-bot merged commit 3261e37 into pingcap:release-3.0 Sep 11, 2019
13 checks passed
13 checks passed
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.