Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix wrong `Flen` when processing `Decimal` and `Int` #12312

Merged
merged 5 commits into from Sep 23, 2019

Conversation

@qw4990
Copy link
Contributor

commented Sep 23, 2019

What problem does this PR solve?

Fix #12301.

Check List

Tests

  • Unit test
@qw4990 qw4990 requested review from XuHuaiyu and zz-jason Sep 23, 2019
@qw4990

This comment has been minimized.

Copy link
Contributor Author

commented Sep 23, 2019

/run-all-tests

Copy link
Member

left a comment

LGTM

Copy link
Contributor

left a comment

LGTM

@sre-bot

This comment has been minimized.

Copy link

commented Sep 23, 2019

Your auto merge job has been accepted, waiting for 12263

@qw4990

This comment has been minimized.

Copy link
Contributor Author

commented Sep 23, 2019

/run-unit-test

@codecov

This comment has been minimized.

Copy link

commented Sep 23, 2019

Codecov Report

Merging #12312 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12312   +/-   ##
===========================================
  Coverage   81.0916%   81.0916%           
===========================================
  Files           454        454           
  Lines         98967      98967           
===========================================
  Hits          80254      80254           
  Misses        12929      12929           
  Partials       5784       5784
@sre-bot

This comment has been minimized.

Copy link

commented Sep 23, 2019

/run-all-tests

@sre-bot sre-bot merged commit 4611383 into pingcap:master Sep 23, 2019
13 checks passed
13 checks passed
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@sre-bot

This comment has been minimized.

Copy link

commented Sep 23, 2019

cherry pick to release-3.0 in PR #12313

@sre-bot

This comment has been minimized.

Copy link

commented Sep 23, 2019

cherry pick to release-2.1 failed

@sre-bot

This comment has been minimized.

Copy link

commented Sep 23, 2019

cherry pick to release-3.1 in PR #12315

sre-bot added a commit that referenced this pull request Sep 24, 2019
) (#12315)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.