Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix drop index failed when index contain auto_increment column and more than 2 index contain auto_increment_column (#12230) #12344

Merged
merged 3 commits into from Sep 24, 2019

Conversation

@sre-bot
Copy link

commented Sep 24, 2019

cherry-pick #12230 to release-3.0


What problem does this PR solve?

create table t (a int auto_increment,b int, unique index (a));
alter table t add index (a,b);
alter table t drop index a; – should execute successful, mysql will sucess.
(1075, u'Incorrect table definition; there can be only one auto column and it must be defined as a key')

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

  • DDL: Fix the issue that drop index on auto_increment column failed when table has more than 2 indexes that contain auto_increment column.
crazycs520 added 2 commits Sep 17, 2019
…nd more than 2 index contain auto_increment_column
@sre-bot

This comment has been minimized.

Copy link
Author

commented Sep 24, 2019

/run-all-tests

Copy link
Member

left a comment

LGTM

Copy link
Member

left a comment

LGTM

@sre-bot

This comment has been minimized.

Copy link
Author

commented Sep 24, 2019

Your auto merge job has been accepted, waiting for 12351, 12354, 12345

@sre-bot

This comment has been minimized.

Copy link
Author

commented Sep 24, 2019

/run-all-tests

@sre-bot sre-bot merged commit d013b31 into pingcap:release-3.0 Sep 24, 2019
13 checks passed
13 checks passed
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.