Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/tikv: fix ttl manager race #12398

Merged
merged 2 commits into from Sep 26, 2019

Conversation

@coocood
Copy link
Member

commented Sep 25, 2019

What problem does this PR solve?

Fix #12396

What is changed and how it works?

run ttlManager after the primary key is successfully set.

Check List

Tests

  • Integration test
@tiancaiamao

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2019

/run-all-tests

@tiancaiamao

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2019

LGTM

@lysu

This comment has been minimized.

Copy link
Member

commented Sep 25, 2019

LGTM

@lysu lysu added status/LGT2 and removed status/LGT1 labels Sep 25, 2019
@lysu

This comment has been minimized.

Copy link
Member

commented Sep 25, 2019

/rebuild

@zz-jason

This comment has been minimized.

Copy link
Member

commented Sep 25, 2019

/run-unit-test

@ngaut
ngaut approved these changes Sep 25, 2019
@codecov

This comment has been minimized.

Copy link

commented Sep 25, 2019

Codecov Report

Merging #12398 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master    #12398   +/-   ##
=========================================
  Coverage   79.655%   79.655%           
=========================================
  Files          461       461           
  Lines       101401    101401           
=========================================
  Hits         80771     80771           
  Misses       14809     14809           
  Partials      5821      5821
@sre-bot

This comment has been minimized.

Copy link

commented Sep 25, 2019

/run-all-tests

@sre-bot

This comment has been minimized.

Copy link

commented Sep 25, 2019

@coocood merge failed.

@tiancaiamao

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2019

/run-unit-test

@lysu

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

/merge

@sre-bot

This comment has been minimized.

Copy link

commented Sep 26, 2019

/run-all-tests

@sre-bot sre-bot merged commit ebce1f0 into pingcap:master Sep 26, 2019
13 checks passed
13 checks passed
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@coocood coocood deleted the coocood:ttl-manager-fix branch Sep 26, 2019
tiancaiamao added a commit to tiancaiamao/tidb that referenced this pull request Sep 26, 2019
tiancaiamao added a commit to tiancaiamao/tidb that referenced this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.