Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store: update kvrpc.Cleanup proto and change its behaviour #12212 #12417

Merged
merged 6 commits into from Oct 9, 2019

Conversation

@tiancaiamao
Copy link
Contributor

tiancaiamao commented Sep 26, 2019

Cherry-pick #12212

tiancaiamao added 2 commits Sep 23, 2019
…mmitted.

After this PR, Cleanup will not rollback a transaction if the lock is active.
@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

tiancaiamao commented Sep 26, 2019

@coocood

This comment has been minimized.

Copy link
Member

coocood commented Sep 26, 2019

LGTM

@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

tiancaiamao commented Oct 8, 2019

/run-all-tests

Copy link
Contributor

MyonKeminta left a comment

LGTM

@MyonKeminta

This comment has been minimized.

Copy link
Contributor

MyonKeminta commented Oct 8, 2019

/run-all-tests tikv=pr/5390

@tiancaiamao tiancaiamao dismissed stale reviews from MyonKeminta and youjiali1995 via cc9a414 Oct 8, 2019
@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

tiancaiamao commented Oct 8, 2019

/run-all-tests tikv=pr/5390

Copy link
Contributor

MyonKeminta left a comment

LGTM

@MyonKeminta

This comment has been minimized.

Copy link
Contributor

MyonKeminta commented Oct 8, 2019

Sorry test were run with wrong version of TiKV.
/run-all-tests tikv=pr/5589

@MyonKeminta

This comment has been minimized.

Copy link
Contributor

MyonKeminta commented Oct 8, 2019

/run-all-tests tikv=pr/5589

@MyonKeminta

This comment has been minimized.

Copy link
Contributor

MyonKeminta commented Oct 8, 2019

/run-all-tests tikv=release-3.0

@sre-bot

This comment has been minimized.

Copy link

sre-bot commented Oct 8, 2019

/run-all-tests

@sre-bot

This comment has been minimized.

Copy link

sre-bot commented Oct 8, 2019

@tiancaiamao merge failed.

@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

tiancaiamao commented Oct 9, 2019

/run-all-tests

@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

tiancaiamao commented Oct 9, 2019

Waiting for #12560 to fix CI (go mod tidy)

@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

tiancaiamao commented Oct 9, 2019

/run-integration-common-test tidb-test=pr/908

@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

tiancaiamao commented Oct 9, 2019

/run-sqllogic-test-1 tidb-test=pr/908

@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

tiancaiamao commented Oct 9, 2019

/run-all-tests

@sre-bot

This comment has been minimized.

Copy link

sre-bot commented Oct 9, 2019

Sorry @tiancaiamao, you don't have permission to trigger auto merge event on this branch.

@coocood coocood merged commit 33f76c9 into pingcap:release-3.0 Oct 9, 2019
13 checks passed
13 checks passed
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@tiancaiamao tiancaiamao deleted the tiancaiamao:cherry-clean-up branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.