Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types/data: the bit data type should be treat as uint64 (#11951) #12423

Merged
merged 5 commits into from Sep 27, 2019

Conversation

@sre-bot
Copy link

commented Sep 26, 2019

cherry-pick #11951 to release-3.0


What problem does this PR solve?

Fix #11895
the -1 can't be insert into a bit column.

What is changed and how it works?

  1. when convert to mysql bit, mapped it to unsigned int.
  2. the error is wrong (it should be data too long instead of out of range)

Check List

Tests

  • Unit test -- added test cases
@sre-bot

This comment has been minimized.

Copy link
Author

commented Sep 26, 2019

/run-all-tests

Copy link
Member

left a comment

LGTM

@qw4990
qw4990 approved these changes Sep 27, 2019
Copy link
Contributor

left a comment

LGTM

@zz-jason zz-jason merged commit b736230 into pingcap:release-3.0 Sep 27, 2019
13 checks passed
13 checks passed
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.