Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: update's select should not change the output columns #12476

Merged
merged 2 commits into from Sep 29, 2019

Conversation

@winoros
Copy link
Member

commented Sep 29, 2019

What problem does this PR solve?

Output columns should change after the select is built.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Write release note for bug-fix or new feature.
@winoros winoros requested review from eurekaka, qw4990 and lzmhhh123 Sep 29, 2019
@winoros winoros changed the title update's select should not change the output columns planner: update's select should not change the output columns Sep 29, 2019
@winoros

This comment has been minimized.

Copy link
Member Author

commented Sep 29, 2019

/run-all-tests

@qw4990

This comment has been minimized.

Copy link
Contributor

commented Sep 29, 2019

/run-common-test

@qw4990

This comment has been minimized.

Copy link
Contributor

commented Sep 29, 2019

/run-integration-common-test

@codecov

This comment has been minimized.

Copy link

commented Sep 29, 2019

Codecov Report

Merging #12476 into master will decrease coverage by 0.2793%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #12476        +/-   ##
================================================
- Coverage   80.0557%   79.7764%   -0.2794%     
================================================
  Files           461        462         +1     
  Lines        103649     102341      -1308     
================================================
- Hits          82977      81644      -1333     
- Misses        14751      14809        +58     
+ Partials       5921       5888        -33
@winkyao

This comment has been minimized.

Copy link
Member

commented Sep 29, 2019

/run-all-tests

@winoros

This comment has been minimized.

Copy link
Member Author

commented Sep 29, 2019

/run-common-test

@winoros

This comment has been minimized.

Copy link
Member Author

commented Sep 29, 2019

/run-integration-common-test

Copy link
Contributor

left a comment

LGTM

@qw4990
qw4990 approved these changes Sep 29, 2019
Copy link
Contributor

left a comment

LGTM

@sre-bot

This comment has been minimized.

Copy link

commented Sep 29, 2019

/run-all-tests

@sre-bot sre-bot merged commit 6169553 into pingcap:master Sep 29, 2019
13 checks passed
13 checks passed
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@sre-bot

This comment has been minimized.

Copy link

commented Sep 29, 2019

cherry pick to release-3.0 failed

@sre-bot

This comment has been minimized.

Copy link

commented Sep 29, 2019

cherry pick to release-3.1 failed

@winoros winoros deleted the winoros:fix-update branch Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.