Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/tikv: implement a `ttlManager` to update the TTL of a transaction (#12177) #12579

Merged
merged 4 commits into from Oct 12, 2019

Conversation

@tiancaiamao
Copy link
Contributor

tiancaiamao commented Oct 9, 2019

Cherry-pick #12177 and #12398

@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

tiancaiamao commented Oct 9, 2019

1 similar comment
@tiancaiamao

This comment has been minimized.

Copy link
Contributor Author

tiancaiamao commented Oct 10, 2019

@coocood

This comment has been minimized.

Copy link
Member

coocood commented Oct 10, 2019

LGTM

Copy link
Contributor

MyonKeminta left a comment

Rest LGTM

@@ -151,5 +151,7 @@ func RegisterMetrics() {
prometheus.MustRegister(TiKVRangeTaskStats)
prometheus.MustRegister(TiKVRangeTaskPushDuration)
prometheus.MustRegister(HandleSchemaValidate)
prometheus.MustRegister(TiKVTokenWaitDuration)

This comment has been minimized.

Copy link
@MyonKeminta

MyonKeminta Oct 11, 2019

Contributor

Is this metric used? Why is it picked into this PR?

This comment has been minimized.

Copy link
@tiancaiamao

tiancaiamao Oct 12, 2019

Author Contributor
Copy link
Contributor

MyonKeminta left a comment

LGTM

@sre-bot

This comment has been minimized.

Copy link

sre-bot commented Oct 12, 2019

/run-all-tests

@sre-bot sre-bot merged commit bb644d1 into pingcap:release-3.0 Oct 12, 2019
13 checks passed
13 checks passed
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@tiancaiamao tiancaiamao deleted the tiancaiamao:cherry-ttl-manager branch Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.