Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, expression: fix simplify outer join with cast (#12701) #12791

Merged
merged 1 commit into from Oct 18, 2019

Conversation

eurekaka
Copy link
Contributor

cherry-pick #12701 and #12782

Conflicts:
planner/core/integration_test.go

@eurekaka
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 pd=release-2.1 tikv=release-2.1

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Oct 17, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 17, 2019

Your auto merge job has been accepted, waiting for 12788

@sre-bot
Copy link
Contributor

sre-bot commented Oct 17, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Oct 17, 2019

@eurekaka merge failed.

@eurekaka
Copy link
Contributor Author

/run-integration-common-test tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

1 similar comment
@ngaut
Copy link
Member

ngaut commented Oct 18, 2019

/run-integration-common-test tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@ngaut ngaut merged commit c72efd1 into pingcap:release-2.1 Oct 18, 2019
@eurekaka eurekaka deleted the pick_cast_21 branch November 13, 2019 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants