Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upperfschema: support performance flame-graph by SQL #12986
Conversation
This comment has been minimized.
This comment has been minimized.
|
can we change the line style? It is verbose to show the prefix As we can see, it is hard to find the actual function, especially when the depth is high. maybe we can change the output format like |
This comment has been minimized.
This comment has been minimized.
Good idea. |
Signed-off-by: Lonng <heng@lonng.org>
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Oct 29, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #12986 +/- ##
================================================
+ Coverage 80.0579% 80.6852% +0.6273%
================================================
Files 468 468
Lines 109367 113152 +3785
================================================
+ Hits 87557 91297 +3740
+ Misses 15118 15080 -38
- Partials 6692 6775 +83 |
This comment has been minimized.
This comment has been minimized.
|
/run-all-tests |
This comment has been minimized.
This comment has been minimized.
|
@siddontang I have tried to trim the prefix but found it's harder to read the result. So I think it's better to keep the current form before we found a better way. |
This comment has been minimized.
This comment has been minimized.
|
LGTM |
|
LGTM |
This comment has been minimized.
This comment has been minimized.
sre-bot
commented
Oct 29, 2019
|
/run-all-tests |
This comment has been minimized.
This comment has been minimized.
sre-bot
commented
Oct 29, 2019
|
cherry pick to release-3.0 failed |
This comment has been minimized.
This comment has been minimized.
sre-bot
commented
Oct 29, 2019
|
cherry pick to release-3.1 failed |
…amegraph by SQL (pingcap#12986) Signed-off-by: Lonng <heng@lonng.org>
…amegraph by SQL (pingcap#12986) Signed-off-by: Lonng <heng@lonng.org>
…amegraph by SQL (pingcap#12986) Signed-off-by: Lonng <heng@lonng.org>

lonng commentedOct 29, 2019
•
edited by dcalvin
Signed-off-by: Lonng heng@lonng.org
What problem does this PR solve?
Currently, we need to get the profile file through the HTTP interface, and then convert the profile file into a flame map (for query cpu/memory/mutex/block/allocs/goroutines) through an external tool. This process is very inefficient and cumbersome.
What is changed and how it works?
Use SQL to directly obtain flamegraph to help us improve diagnostic efficiency.
Note: This PR is part of Hackathon 2019 TBSSQL2.0.
eg:
And we can filter some leavies easily.
Check List
Tests
Code changes
Related changes
Release note