Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: implement restore function for KindMysqlDuration and KindMysqlTime #13242

Merged
merged 5 commits into from Jan 9, 2020

Conversation

@you06
Copy link
Contributor

you06 commented Nov 7, 2019

What problem does this PR solve?

Implement restore function for KindMysqlDuration and KindMysqlTime for generating SQL string from AST.

What is changed and how it works?

Restore by using String function already defined for KindMysqlDuration and KindMysqlTime.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
you06 added 2 commits Nov 7, 2019
Signed-off-by: you06 <you1474600@gmail.com>
fix bug
Signed-off-by: you06 <you1474600@gmail.com>
@@ -33,7 +33,7 @@ func TestT(t *testing.T) {
type testTimeSuite struct{}

func (s *testTimeSuite) TestgetTZNameFromFileName(c *C) {
tz, err := inferTZNameFromFileName("/user/share/zoneinfo/Asia/Shanghai")
tz, err := inferTZNameFromFileName("/usr/share/zoneinfo/Asia/Shanghai")

This comment has been minimized.

Copy link
@you06

you06 Nov 7, 2019

Author Contributor

I'm not sure if this is a typo or testing for invalid directory.

@you06 you06 requested review from leoppro and zhexuany Nov 7, 2019
you06 added 2 commits Nov 7, 2019
fix ci
Signed-off-by: you06 <you1474600@gmail.com>
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 7, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@07e642c). Click here to learn what that means.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master     #13242   +/-   ##
===========================================
  Coverage          ?   80.1722%           
===========================================
  Files             ?        469           
  Lines             ?     111490           
  Branches          ?          0           
===========================================
  Hits              ?      89384           
  Misses            ?      15206           
  Partials          ?       6900
@you06

This comment has been minimized.

Copy link
Contributor Author

you06 commented Nov 7, 2019

/run-check_dev

Copy link
Member

zz-jason left a comment

LGTM

@zz-jason zz-jason requested review from lamxTyler and removed request for zhexuany Dec 29, 2019
@zz-jason zz-jason added the status/PTAL label Jan 6, 2020
@zz-jason zz-jason requested review from winoros and removed request for leoppro Jan 6, 2020
@sre-bot

This comment has been minimized.

Copy link

sre-bot commented Jan 8, 2020

@you06

This comment has been minimized.

Copy link
Contributor Author

you06 commented Jan 8, 2020

/run-check_dev_2

Copy link
Member

lamxTyler left a comment

LGTM

@sre-bot

This comment has been minimized.

Copy link

sre-bot commented Jan 9, 2020

/run-all-tests

@sre-bot sre-bot merged commit 0a0e388 into pingcap:master Jan 9, 2020
15 checks passed
15 checks passed
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-copr-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/wasm-build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.