Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign updistsql: Unify endian for Chunk encode format #13349
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
/build |
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Nov 12, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #13349 +/- ##
===========================================
Coverage 80.1863% 80.1863%
===========================================
Files 474 474
Lines 116753 116753
===========================================
Hits 93620 93620
Misses 15761 15761
Partials 7372 7372 |
This comment has been minimized.
This comment has been minimized.
|
/run-all-tests |
distsql/distsql.go
Outdated
| @@ -169,5 +170,35 @@ func canUseChunkRPC(ctx sessionctx.Context) bool { | |||
| if ctx.GetSessionVars().EnableStreaming { | |||
| return false | |||
| } | |||
| if !supportedAlignment() { | |||
This comment has been minimized.
This comment has been minimized.
SunRunAway
Nov 25, 2019
Member
We may check this when process starting and cache the result, instead of checking in each session.
distsql/distsql.go
Outdated
|
|
||
| // SetSystemEndian sets the system endian for the DAGRequest. | ||
| func SetSystemEndian(dagReq *tipb.DAGRequest) { | ||
| dagReq.TidbSystemEndian = GetSystemEndian() |
This comment has been minimized.
This comment has been minimized.
SunRunAway
Nov 25, 2019
Member
We may check this when process starting and cache the result, instead of checking in each session.
This comment has been minimized.
This comment has been minimized.
|
And PTAL at the CI failure. |
This comment has been minimized.
This comment has been minimized.
The CI fail is because tipb hasn't been merged to master and update. |
|
LGTM |
SunRunAway
changed the title
|
LGTM |
This comment has been minimized.
This comment has been minimized.
sre-bot
commented
Nov 27, 2019
|
/run-all-tests |
edytagarbarz
added a commit
to edytagarbarz/tidb
that referenced
this pull request
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
wshwsh12 commentedNov 11, 2019
What problem does this PR solve?
When using chunk encode format for response , maybe the endian is different in tidb and tikv, and tidb can't decode the data.
What is changed and how it works?
Unify endian for Chunk encode format.
Check List
Tests
Code changes
Side effects
Related changes
Release note