Enable 15 push down functions #13496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Breezewish <me@breeswish.org>
ghost
requested review from
wshwsh12 and
XuHuaiyu
and removed request for
a team
Signed-off-by: Breezewish <me@breeswish.org>
breezewish
changed the title
lonng
reviewed
Nov 15, 2019
Codecov Report
@@ Coverage Diff @@
## master #13496 +/- ##
=========================================
Coverage 80.089% 80.089%
=========================================
Files 472 472
Lines 115499 115499
=========================================
Hits 92502 92502
Misses 15743 15743
Partials 7254 7254 |
|
/run-all-tests |
Signed-off-by: Breezewish <me@breeswish.org>
|
/run-all-tests |
Signed-off-by: Breezewish <me@breeswish.org>
|
/run-all-tests |
AilinKid
reviewed
Nov 19, 2019
| //case tipb.ScalarFuncSig_RowSig: | ||
| case tipb.ScalarFuncSig_SetVar: | ||
| f = &builtinSetVarSig{base} | ||
| //case tipb.ScalarFuncSig_ValuesDecimal: |
There was a problem hiding this comment.
Means they are either not implemented by TiDB (so that there is no builtinXxxSig), or they are implemented but require additional parameters (like {base, xx, yy}) that I don't know how to fill for now.
lonng
approved these changes
Nov 19, 2019
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Breezewish me@breeswish.org
What problem does this PR solve?
Enable 15 push down functions
What is changed and how it works?
Related tests:
tikv/copr-test#21
tikv/copr-test#24
tikv/copr-test#25
tikv/copr-test#11
tikv/copr-test#9
tikv/copr-test#32
tikv/copr-test#29
tikv/copr-test#23
Check List
Tests