Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: show `max-proc-keys` and `p95-proc-keys` in results of `explain analyze` #13692

Merged
merged 8 commits into from Nov 27, 2019

Conversation

@qw4990
Copy link
Contributor

qw4990 commented Nov 22, 2019

What problem does this PR solve?

Show max-proc-keys and p95-proc-keys in the results of explain analyze, which can help us to check if there are hot regions.

After this PR:

| └─TableReader_17       | 1.00  | root      | data:StreamAgg_8                                           | time:247.008µs, loops:200, rows:201010, rpc time:183.957µs, proc keys max:101010, p95:2000   | 137 Bytes |

Check List

Tests

  • Unit test
@qw4990 qw4990 requested review from lzmhhh123, zz-jason and wshwsh12 and removed request for lzmhhh123 Nov 22, 2019
Copy link
Member

lzmhhh123 left a comment

Fix the explain tests? Others are looked good to me.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #13692 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13692   +/-   ##
===========================================
  Coverage   80.1681%   80.1681%           
===========================================
  Files           474        474           
  Lines        116898     116898           
===========================================
  Hits          93715      93715           
  Misses        15810      15810           
  Partials       7373       7373
@qw4990

This comment has been minimized.

Copy link
Contributor Author

qw4990 commented Nov 26, 2019

/run-all-tests

@qw4990

This comment has been minimized.

Copy link
Contributor Author

qw4990 commented Nov 26, 2019

Fix the explain tests? Others are looked good to me.

Fixed, PTAL~ @lzmhhh123

Copy link
Member

lzmhhh123 left a comment

LGTM

@qw4990 qw4990 requested a review from Reminiscent Nov 26, 2019
Copy link
Contributor

wshwsh12 left a comment

LGTM

@sre-bot

This comment has been minimized.

Copy link

sre-bot commented Nov 27, 2019

/run-all-tests

@sre-bot sre-bot merged commit e4bdb7b into pingcap:master Nov 27, 2019
14 checks passed
14 checks passed
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-copr-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
qw4990 added a commit to qw4990/tidb that referenced this pull request Nov 27, 2019
SunRunAway added a commit to SunRunAway/tidb that referenced this pull request Dec 2, 2019
edytagarbarz added a commit to edytagarbarz/tidb that referenced this pull request Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.