Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perfschema: support retrieve CPU/memory/mutex/block/allocs profile from PD via SQL #13717

Merged
merged 6 commits into from Nov 29, 2019

Conversation

@lonng
Copy link
Member

lonng commented Nov 25, 2019

What problem does this PR solve?

perfschema: support retrieve CPU/memory/mutex/block/allocs profile from PD via SQL

What is changed and how it works?

Add system tables in PERFORMANCE_SCHEMA

pd_profile_cpu
pd_profile_memory
pd_profile_mutex
pd_profile_allocs
pd_profile_block
pd_profile_goroutines

Check List

Tests

  • Unit test

Release note

  • Support retrieve CPU/memory/mutex/block/allocs profile from PD via SQL (eg: select * from performance_schema.pd_profile_memory).
@sre-bot

This comment has been minimized.

Copy link

sre-bot commented Nov 25, 2019

Thanks for your PR.
This PR will be closed by bot because you already had 3 opened PRs, close or merge them before submitting a new one.
#13270 , #13481 , #13711

@sre-bot sre-bot closed this Nov 25, 2019
@lonng lonng added this to In progress in Built-in SQL Diagnostics Nov 25, 2019
@lonng lonng added status/DNM and removed closed/no-pr-quota labels Nov 25, 2019
@lonng lonng reopened this Nov 25, 2019
@sre-bot sre-bot closed this Nov 25, 2019
@lonng lonng mentioned this pull request Nov 25, 2019
26 of 60 tasks complete
@lonng lonng reopened this Nov 25, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 25, 2019

Codecov Report

Merging #13717 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13717   +/-   ##
===========================================
  Coverage   80.1631%   80.1631%           
===========================================
  Files           474        474           
  Lines        117105     117105           
===========================================
  Hits          93875      93875           
  Misses        15830      15830           
  Partials       7400       7400
@lonng lonng force-pushed the lonng:pd-profile branch 2 times, most recently from 9d3a214 to d387830 Nov 25, 2019
@lonng lonng force-pushed the lonng:pd-profile branch from d387830 to 80a0ed9 Nov 28, 2019
lonng added 2 commits Nov 25, 2019
…om PD via SQL

Signed-off-by: Lonng <heng@lonng.org>
fix test
Signed-off-by: Lonng <heng@lonng.org>
@lonng lonng force-pushed the lonng:pd-profile branch from 80a0ed9 to 6a3a907 Nov 28, 2019
@lonng lonng removed the status/DNM label Nov 28, 2019
@lonng lonng requested review from AilinKid and djshow832 Nov 28, 2019
infoschema/perfschema/tables.go Outdated Show resolved Hide resolved
infoschema/perfschema/tables.go Outdated Show resolved Hide resolved
util/profile/profile.go Outdated Show resolved Hide resolved
lonng added 2 commits Nov 28, 2019
Signed-off-by: Lonng <heng@lonng.org>
fix build
Signed-off-by: Lonng <heng@lonng.org>
@pingcap pingcap deleted a comment from sre-bot Nov 28, 2019
Copy link
Contributor

djshow832 left a comment

LGTM

Copy link
Member

crazycs520 left a comment

LGTM

@crazycs520

This comment has been minimized.

Copy link
Member

crazycs520 commented Nov 29, 2019

/run-all-tests

@lonng

This comment has been minimized.

Copy link
Member Author

lonng commented Nov 29, 2019

/merge

@sre-bot

This comment has been minimized.

Copy link

sre-bot commented Nov 29, 2019

/run-all-tests

@lonng lonng merged commit d438c86 into pingcap:master Nov 29, 2019
14 checks passed
14 checks passed
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-copr-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@lonng lonng deleted the lonng:pd-profile branch Nov 29, 2019
SunRunAway added a commit to SunRunAway/tidb that referenced this pull request Dec 2, 2019
…om PD via SQL (pingcap#13717)

Signed-off-by: Lonng <heng@lonng.org>
edytagarbarz added a commit to edytagarbarz/tidb that referenced this pull request Dec 5, 2019
…om PD via SQL (pingcap#13717)

Signed-off-by: Lonng <heng@lonng.org>
@lonng lonng moved this from In progress to Done in Built-in SQL Diagnostics Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.