Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/printer: get `GoVersion` from runtime variable instead of shell #13763

Merged
merged 5 commits into from Nov 27, 2019

Conversation

@coocood
Copy link
Member

coocood commented Nov 27, 2019

What problem does this PR solve?

If we build tidb-server with a different go binary rather than the default go, the GoVersion may be wrong.

What is changed and how it works?

link runtime buildVersion variable in printer to get the GoVersion.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    make server and run tidb-server -V
@coocood coocood requested review from jackysp and lysu Nov 27, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #13763 into master will decrease coverage by 0.2973%.
The diff coverage is 50%.

@@               Coverage Diff                @@
##             master     #13763        +/-   ##
================================================
- Coverage   80.3674%   80.0701%   -0.2974%     
================================================
  Files           477        474         -3     
  Lines        119465     116599      -2866     
================================================
- Hits          96011      93361      -2650     
+ Misses        16071      15864       -207     
+ Partials       7383       7374         -9
Copy link
Member

lysu left a comment

LGTM, and need gofmt

Copy link
Member

jackysp left a comment

LGTM

@sre-bot

This comment has been minimized.

Copy link

sre-bot commented Nov 27, 2019

/run-all-tests

@sre-bot sre-bot merged commit 04fc7cc into pingcap:master Nov 27, 2019
14 checks passed
14 checks passed
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/common-test job succeeded
Details
idc-jenkins-ci-tidb/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-copr-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/mybatis-test job succeeded
Details
idc-jenkins-ci-tidb/sqllogic-test-1 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/sqllogic-test-2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@coocood coocood deleted the coocood:go-version branch Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.