infoschema: refactor GetClusterServerInfo to avoid executing internal SQL #13765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lonng <heng@lonng.org>
Codecov Report
@@ Coverage Diff @@
## master #13765 +/- ##
===========================================
Coverage 80.0626% 80.0626%
===========================================
Files 474 474
Lines 117107 117107
===========================================
Hits 93759 93759
Misses 15964 15964
Partials 7384 7384 |
crazycs520
reviewed
Nov 27, 2019
crazycs520
reviewed
Nov 27, 2019
|
/run-all-tests |
|
Change the PR title: inforschema => infoschema, execute => executing. |
lonng
changed the title
|
@djshow832 Please approve this PR. |
djshow832
approved these changes
Nov 27, 2019
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
qw4990
pushed a commit
to qw4990/tidb
that referenced
this pull request
Nov 27, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lonng heng@lonng.org
What problem does this PR solve?
In the current implementation, we must to execute
SELECT type, address, status_address FROM INFORMATION_SCHEMA.TIDB_CLUSTER_INFO ORDER BY typeto obtain cluster topology. That's inefficient.What is changed and how it works?
This PR refactor this part and extras an individual function to obtains cluster topology and make other functions work more easily.
Check List
Tests
Code changes
Release note