Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: Fix potential timezone related bugs caused by gotime.Local (#13752) #13793

Merged
merged 4 commits into from Nov 28, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Nov 28, 2019

cherry-pick #13752 to release-3.0


What problem does this PR solve?

#13626

What is changed and how it works?

Use sc.TimeZone to create time variable when we round time in RoundFrac.

Check List

Tests

None

Code changes

None

Side effects

None

Related changes

None

Release note

None

@sre-bot
Copy link
Contributor Author

sre-bot commented Nov 28, 2019

/run-all-tests

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Deardrops
Copy link
Contributor

/run-all-tests

Copy link
Contributor

@Deardrops Deardrops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Deardrops Deardrops added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 28, 2019
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 merged commit 16781a3 into pingcap:release-3.0 Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants