Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support stream when read cluster memory table. #14344

Merged
merged 19 commits into from Jan 9, 2020

Conversation

@crazycs520
Copy link
Member

crazycs520 commented Jan 3, 2020

What problem does this PR solve?

Before this PR, TiDB doesn't support reading cluster memory table with stream.

What is changed and how it works?

  • Implement CoprocessorStream interface for rpc_server to support stream.
  • Turn on stream when reading cluster memory table.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change

Side effects

@crazycs520 crazycs520 requested a review from pingcap/co-planner as a code owner Jan 3, 2020
@pull-assigner pull-assigner bot requested review from lamxTyler and winoros and removed request for pingcap/co-planner Jan 3, 2020
executor/coprocessor.go Outdated Show resolved Hide resolved
executor/coprocessor.go Outdated Show resolved Hide resolved
server/rpc_server.go Outdated Show resolved Hide resolved
store/mockstore/mocktikv/rpc.go Outdated Show resolved Hide resolved
server/rpc_server.go Outdated Show resolved Hide resolved
store/mockstore/mocktikv/rpc.go Outdated Show resolved Hide resolved
executor/coprocessor.go Outdated Show resolved Hide resolved
crazycs520 added 2 commits Jan 7, 2020
store/mockstore/mocktikv/rpc.go Outdated Show resolved Hide resolved
executor/coprocessor.go Outdated Show resolved Hide resolved
infoschema/tables_test.go Show resolved Hide resolved
server/rpc_server.go Outdated Show resolved Hide resolved
crazycs520 added 3 commits Jan 7, 2020
Copy link
Member

bb7133 left a comment

LGTM

executor/coprocessor.go Outdated Show resolved Hide resolved
executor/coprocessor.go Outdated Show resolved Hide resolved
crazycs520 added 2 commits Jan 8, 2020
Copy link
Member

wjhuang2016 left a comment

LGTM

@crazycs520

This comment has been minimized.

Copy link
Member Author

crazycs520 commented Jan 9, 2020

/run-all-tests

crazycs520 added 3 commits Jan 9, 2020
@crazycs520

This comment has been minimized.

Copy link
Member Author

crazycs520 commented Jan 9, 2020

/run-all-tests

@crazycs520 crazycs520 merged commit 3f7df97 into pingcap:master Jan 9, 2020
7 checks passed
7 checks passed
idc-jenkins-ci-tidb/build Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/build_check_race Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/check_dev_2 Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/unit-test Jenkins job succeeded.
Details
idc-jenkins-ci-tidb/wasm-build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.