Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix transaction lazy initialization in pessimistic mode (#14446) #14474

Merged
merged 3 commits into from Jan 15, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jan 14, 2020

cherry-pick #14446 to release-3.0


Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What problem does this PR solve?

The transaction should also be initialized lazily in the pessimistic mode.

What is changed and how it works?

Do not active Txn when handling pessimistic DMLs.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Related changes

  • Need to cherry-pick to the release branch

Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 14, 2020

/run-all-tests

@coocood
Copy link
Member

coocood commented Jan 14, 2020

LGTM

@bb7133 bb7133 added this to the v3.0.10 milestone Jan 15, 2020
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented Jan 15, 2020

/run-unit-test

@jackysp
Copy link
Member

jackysp commented Jan 15, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 15, 2020

Your auto merge job has been accepted, waiting for 14439

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 15, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 15, 2020

/run-all-tests

@jackysp jackysp merged commit 91f8a2a into pingcap:release-3.0 Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. type/bug-fix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants