Skip to content

planner: Fix SMJ hint, support SMJ with descending order (#14505)#14664

Merged
sre-bot merged 4 commits into
pingcap:release-3.0from
ichn-hu:cherry-pick-3.0
Feb 25, 2020
Merged

planner: Fix SMJ hint, support SMJ with descending order (#14505)#14664
sre-bot merged 4 commits into
pingcap:release-3.0from
ichn-hu:cherry-pick-3.0

Conversation

@ichn-hu

@ichn-hu ichn-hu commented Feb 6, 2020

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Cherry-pick #14505 to 3.0

What is changed and how it works?

Changes are brought from #14505

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note

  • Fixing a correctness bug in sort merge join executor, support SMJ in descending order.

@ichn-hu

ichn-hu commented Feb 6, 2020

Copy link
Copy Markdown
Contributor Author

@SunRunAway PTAL, hand over to you as well~

@SunRunAway SunRunAway left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 24, 2020
@SunRunAway SunRunAway added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Feb 24, 2020

@zz-jason zz-jason left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 25, 2020
@SunRunAway

Copy link
Copy Markdown
Contributor

/merge

@sre-bot

sre-bot commented Feb 25, 2020

Copy link
Copy Markdown
Contributor

/run-all-tests

@sre-bot sre-bot merged commit f68baab into pingcap:release-3.0 Feb 25, 2020
@ichn-hu ichn-hu changed the title planner: Fix SMJ hint, support SMJ with descending order planner: Fix SMJ hint, support SMJ with descending order (cherry-pick #14505) Apr 7, 2020
@ichn-hu ichn-hu changed the title planner: Fix SMJ hint, support SMJ with descending order (cherry-pick #14505) planner: Fix SMJ hint, support SMJ with descending order (#14505) Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants