*: use the revertable sandbox to buffer mutations #15931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
bobotu
requested review from
tiancaiamao,
coocood and
jackysp
and removed request for
qw4990
|
/run-all-tests |
github-actions
bot
added
sig/sql-infra
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #15931 +/- ##
================================================
+ Coverage 80.4524% 80.9001% +0.4476%
================================================
Files 506 506
Lines 135393 137577 +2184
================================================
+ Hits 108927 111300 +2373
+ Misses 17958 17784 -174
+ Partials 8508 8493 -15 |
tiancaiamao
reviewed
Apr 1, 2020
|
/run-all-tests |
3 similar comments
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
coocood
reviewed
Apr 2, 2020
kv/kv.go
Outdated
| // | ||
| // Note: you cannot modify this MemBuffer until the child buffer finished, | ||
| // otherwise the Set operation will panic. | ||
| NewBuffer() MemBuffer |
There was a problem hiding this comment.
NewChildBuffer may be more clear.
|
/run-all-tests |
|
/bench +tpcc +sysbench |
Benchmark Report
@@ Benchmark Diff @@
================================================================================
--- tidb: 827edde58535ac585b4b01473a854f1d923bb54a
+++ tidb: f7fcdc25da9292b539904b4998960761faa49b57
tikv: 50397a6e9f9e4f80ac640ec2b4bf6b1315ebb9d7
pd: fccb3d434acccb7256cacdd7c958a5996c2d870d
================================================================================
Measured tpmC (NewOrders): 7158.96 ± 1.05% (std=47.40), delta: 0.02% (p=0.978) |
Benchmark Report
@@ Benchmark Diff @@
================================================================================
--- tidb: 827edde58535ac585b4b01473a854f1d923bb54a
+++ tidb: f7fcdc25da9292b539904b4998960761faa49b57
tikv: 50397a6e9f9e4f80ac640ec2b4bf6b1315ebb9d7
pd: a22224df124e8a8f9261e4129751200255db6f2c
================================================================================
oltp_update_index:
* QPS: 4343.46 ± 0.13% (std=4.67) delta: 0.53% (p=0.139)
* Latency p50: 29.46 ± 0.15% (std=0.03) delta: -0.25%
* Latency p99: 53.86 ± 3.57% (std=1.18) delta: 0.89%
oltp_insert:
* QPS: 7045.55 ± 0.37% (std=19.16) delta: 1.69% (p=0.000)
* Latency p50: 18.16 ± 0.34% (std=0.05) delta: -1.66%
* Latency p99: 31.75 ± 1.20% (std=0.27) delta: -3.28%
oltp_read_write:
* QPS: 14314.81 ± 1.49% (std=148.87) delta: -0.27% (p=0.883)
* Latency p50: 179.19 ± 1.49% (std=1.88) delta: 0.26%
* Latency p99: 326.09 ± 3.57% (std=8.23) delta: -2.65%
oltp_point_select:
* QPS: 41337.52 ± 0.76% (std=203.87) delta: -0.31% (p=0.402)
* Latency p50: 3.09 ± 0.81% (std=0.02) delta: 0.32%
* Latency p99: 11.04 ± 0.00% (std=0.00) delta: 2.44%
oltp_update_non_index:
* QPS: 4754.05 ± 0.34% (std=10.06) delta: 0.07% (p=0.324)
* Latency p50: 26.92 ± 0.33% (std=0.05) delta: -0.08%
* Latency p99: 40.86 ± 1.19% (std=0.34) delta: -0.59%
|
|
LGTM |
|
/run-all-tests |
|
/run-unit-test |
|
LGTM |
tiancaiamao
approved these changes
Apr 3, 2020
jackysp
reviewed
Apr 3, 2020
| } | ||
|
|
||
| // SetCap sets the MemBuffer capability. | ||
| func (s *BufferStore) SetCap(cap int) { |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 15, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-4.0 in PR #16400 |
zz-jason
pushed a commit
that referenced
this pull request
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
After #15780, this PR update the other parts of TiDB to use the new
FlushandDiscardAPI.What is changed and how it works?
Update the
MemBufferinterface:FlushandDiscardrespect toSandbox's APINewBufferto derive a newSandboxResetandSetCapbecause there is no need to use themThe
TxnState's buffer now directly derived from the underlyingTransactionwhen its state changed tovalid. When statement commit/rollback the buffer will be discarded and a newSandboxwill be created (this allocation can be reduced by pooling temporalSandbox, I'll submit a separate PR to add this optimization)