ddl, planner: support ALTER TABLE without use db (#18784)
#19471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
contribution
ti-srebot
added
status/LGT2
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@ti-srebot merge failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #18784 to release-4.0
What problem does this PR solve?
Issue Number: close #18756
Problem Summary:
alter table db.t1 add constraint fk foreign key (c2) references t2(c1)without first executinguse db, TiDB will reportNo database selected. That is becausec2has no schema(dbName), nor do we have a globalCurrentDB. But mysql will try to use dbName fromdb.t1. Manually tested.Check List
Tests
Release note
alter table db.t1 add constraint fk foreign key (c2) references t2(c1)like statements without first executinguse db