diff --git a/executor/aggfuncs/aggfunc_test.go b/executor/aggfuncs/aggfunc_test.go index ea2f3540d18a5..368cfc889bd3b 100644 --- a/executor/aggfuncs/aggfunc_test.go +++ b/executor/aggfuncs/aggfunc_test.go @@ -241,8 +241,8 @@ type aggMemTest struct { isDistinct bool } -func buildAggMemTester(funcName string, tp byte, numRows int, allocMemDelta int64, updateMemDeltaGens updateMemDeltaGens, isDistinct bool, results ...interface{}) aggMemTest { - aggTest := buildAggTester(funcName, tp, numRows, results) +func buildAggMemTester(funcName string, tp byte, numRows int, allocMemDelta int64, updateMemDeltaGens updateMemDeltaGens, isDistinct bool) aggMemTest { + aggTest := buildAggTester(funcName, tp, numRows) pt := aggMemTest{ aggTest: aggTest, allocMemDelta: allocMemDelta, diff --git a/executor/aggfuncs/func_avg_test.go b/executor/aggfuncs/func_avg_test.go index c707619c2deef..09d62dd45168b 100644 --- a/executor/aggfuncs/func_avg_test.go +++ b/executor/aggfuncs/func_avg_test.go @@ -45,13 +45,13 @@ func (s *testSuite) TestAvg(c *C) { func (s *testSuite) TestMemAvg(c *C) { tests := []aggMemTest{ buildAggMemTester(ast.AggFuncAvg, mysql.TypeNewDecimal, 5, - aggfuncs.DefPartialResult4AvgDecimalSize, defaultUpdateMemDeltaGens, false, nil, 2.0), + aggfuncs.DefPartialResult4AvgDecimalSize, defaultUpdateMemDeltaGens, false), buildAggMemTester(ast.AggFuncAvg, mysql.TypeNewDecimal, 5, - aggfuncs.DefPartialResult4AvgDistinctDecimalSize, distinctUpdateMemDeltaGens, true, nil, 2.0), + aggfuncs.DefPartialResult4AvgDistinctDecimalSize, distinctUpdateMemDeltaGens, true), buildAggMemTester(ast.AggFuncAvg, mysql.TypeDouble, 5, - aggfuncs.DefPartialResult4AvgFloat64Size, defaultUpdateMemDeltaGens, false, nil, 2.0), + aggfuncs.DefPartialResult4AvgFloat64Size, defaultUpdateMemDeltaGens, false), buildAggMemTester(ast.AggFuncAvg, mysql.TypeDouble, 5, - aggfuncs.DefPartialResult4AvgDistinctFloat64Size, distinctUpdateMemDeltaGens, true, nil, 2.0), + aggfuncs.DefPartialResult4AvgDistinctFloat64Size, distinctUpdateMemDeltaGens, true), } for _, test := range tests { s.testAggMemFunc(c, test) diff --git a/executor/aggfuncs/func_count_test.go b/executor/aggfuncs/func_count_test.go index f2dccca9a1626..a52f48efa53f3 100644 --- a/executor/aggfuncs/func_count_test.go +++ b/executor/aggfuncs/func_count_test.go @@ -22,7 +22,6 @@ import ( "github.com/pingcap/parser/ast" "github.com/pingcap/parser/mysql" "github.com/pingcap/tidb/executor/aggfuncs" - "github.com/pingcap/tidb/util/israce" ) func genApproxDistinctMergePartialResult(begin, end uint64) string { @@ -103,30 +102,27 @@ func (s *testSuite) TestCount(c *C) { } func (s *testSuite) TestMemCount(c *C) { - if israce.RaceEnabled { - c.Skip("skip race test") - } tests := []aggMemTest{ buildAggMemTester(ast.AggFuncCount, mysql.TypeLonglong, 5, - aggfuncs.DefPartialResult4CountDistinctIntSize, distinctUpdateMemDeltaGens, true, 0, 5), + aggfuncs.DefPartialResult4CountDistinctIntSize, distinctUpdateMemDeltaGens, true), buildAggMemTester(ast.AggFuncCount, mysql.TypeFloat, 5, - aggfuncs.DefPartialResult4CountDistinctRealSize, distinctUpdateMemDeltaGens, true, 0, 5), + aggfuncs.DefPartialResult4CountDistinctRealSize, distinctUpdateMemDeltaGens, true), buildAggMemTester(ast.AggFuncCount, mysql.TypeDouble, 5, - aggfuncs.DefPartialResult4CountDistinctRealSize, distinctUpdateMemDeltaGens, true, 0, 5), + aggfuncs.DefPartialResult4CountDistinctRealSize, distinctUpdateMemDeltaGens, true), buildAggMemTester(ast.AggFuncCount, mysql.TypeNewDecimal, 5, - aggfuncs.DefPartialResult4CountDistinctDecimalSize, distinctUpdateMemDeltaGens, true, 0, 5), + aggfuncs.DefPartialResult4CountDistinctDecimalSize, distinctUpdateMemDeltaGens, true), buildAggMemTester(ast.AggFuncCount, mysql.TypeString, 5, - aggfuncs.DefPartialResult4CountDistinctStringSize, distinctUpdateMemDeltaGens, true, 0, 5), + aggfuncs.DefPartialResult4CountDistinctStringSize, distinctUpdateMemDeltaGens, true), buildAggMemTester(ast.AggFuncCount, mysql.TypeDate, 5, - aggfuncs.DefPartialResult4CountWithDistinctSize, distinctUpdateMemDeltaGens, true, 0, 5), + aggfuncs.DefPartialResult4CountWithDistinctSize, distinctUpdateMemDeltaGens, true), buildAggMemTester(ast.AggFuncCount, mysql.TypeDuration, 5, - aggfuncs.DefPartialResult4CountDistinctDurationSize, distinctUpdateMemDeltaGens, true, 0, 5), + aggfuncs.DefPartialResult4CountDistinctDurationSize, distinctUpdateMemDeltaGens, true), buildAggMemTester(ast.AggFuncCount, mysql.TypeJSON, 5, - aggfuncs.DefPartialResult4CountWithDistinctSize, distinctUpdateMemDeltaGens, true, 0, 5), - buildAggMemTester(ast.AggFuncApproxCountDistinct, mysql.TypeLonglong, 100000, - aggfuncs.DefPartialResult4ApproxCountDistinctSize, approxCountDistinctUpdateMemDeltaGens, true, 0, 100000), - buildAggMemTester(ast.AggFuncApproxCountDistinct, mysql.TypeString, 100000, - aggfuncs.DefPartialResult4ApproxCountDistinctSize, approxCountDistinctUpdateMemDeltaGens, true, 0, 100000), + aggfuncs.DefPartialResult4CountWithDistinctSize, distinctUpdateMemDeltaGens, true), + buildAggMemTester(ast.AggFuncApproxCountDistinct, mysql.TypeLonglong, 5, + aggfuncs.DefPartialResult4ApproxCountDistinctSize, approxCountDistinctUpdateMemDeltaGens, true), + buildAggMemTester(ast.AggFuncApproxCountDistinct, mysql.TypeString, 5, + aggfuncs.DefPartialResult4ApproxCountDistinctSize, approxCountDistinctUpdateMemDeltaGens, true), } for _, test := range tests { s.testAggMemFunc(c, test)