Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Set the error of schema expired to retryable error #2110

Merged
merged 5 commits into from Nov 29, 2016

Conversation

zimulala
Copy link
Contributor

*: set the error of schema expired to retryable error
domain: rename an error name

@zimulala
Copy link
Contributor Author

PTAL @shenli @coocood @tiancaiamao


if err := s.checkSchemaValid(); err != nil {
if !s.sessionVars.RetryInfo.Retrying {
err = s.Retry()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain.ErrInfoSchemaExpired is not kv.IsRetryableError, Retry will only retry once.

@@ -119,6 +118,7 @@ type session struct {
values map[fmt.Stringer]interface{}
store kv.Storage
history stmtHistory
currRetryCnt int // current retry times
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unnecessary.

@coocood
Copy link
Member

coocood commented Nov 29, 2016

LGTM

1 similar comment
@tiancaiamao
Copy link
Contributor

LGTM

@zimulala zimulala merged commit 6ae4cfd into master Nov 29, 2016
@zimulala zimulala deleted the zimuxia/retry-error branch November 29, 2016 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants